Just thought of some not functional but for documentation. The mod enum has comments relating to the old physical SDTs not being the same base values as the others.

I don't know if this ever came up in the past, but should we rename these mods to imply that they're 1/10000 1e4-based, etc.

SLASH_SDT -> SLASH_SDT_BASE_10K? Just really hammer it home forever? I wouldn't be against us marking other things with types too: ..._FLOAT, _PERCENT, _something that indicates 0.0 to 1.0, etc.

I wouldnt be opposed to changing the modifier naming conventions. Or implementing a convention in the first place.

With this change, now all _SDT mods use 10k as base and all function the same (positive -> more damage, negative .> less damage)
This was more something that was bound to happen. We started this a year or 2 ago and we just didnt finish it.

I think because this has been an issue for so long, and it's just a "thing you have to know" once you're up in Lua - and nobody is going to go read the comments next to where these mods/enums are defined: we should add things like _BASE_10K, _PERCENT, etc. to things that are of an arbitrary scale. We don't need to add this sort of annotation for things that line up in-game like DEF, etc.

We talked about this offline - the naming convention changes can happen in a later PR 👍